Skip to content

Remove dependency on index path #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2015
Merged

Remove dependency on index path #4

merged 3 commits into from
Apr 27, 2015

Conversation

achambers
Copy link
Member

This PR does the following:

  • Validates config in the willDeploy hook
  • Uses a filePattern to determine which file to use as the index file
  • Use the user defined config over the context attrs

@achambers
Added willDeploy hook to validate config
62fc4dc
@achambers
Adding type as an optional config field
4b69208
@achambers
Now we use the filePattern to know which file to tag.
ddb868e 
This is instead of using a property called indexPath as it may not be
the index.html that the user wants to hash
achambers pushed a commit that referenced this pull request Apr 27, 2015
Merge pull request #4 from strange-studios/remove-dependency-on-index…
11ee781 
…-path

Remove dependency on index path
@achambers achambers merged commit 11ee781 into ember-cli-deploy:master Apr 27, 2015
@achambers achambers deleted the remove-dependency-on-index-path branch April 27, 2015 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achambers