Allow custom commit hash length when constructing revisionKey #71
Conversation
Fixes ember-cli-deploy#22 This allows the length of the commit hash that is used to be configured. This applies to the `git-commit`, `git-tag-commit`, and `version-commit` data generator types. Example usage: ```js ENV['revision-data'] = { type: 'git-commit', commitHashLength: 40 } ``` This example would cause the entire commit hash to be used as the `revisionKey`.
| @@ -15,6 +15,15 @@ module.exports = { | |||
| separator: '+', | |||
| filePattern: 'index.html', | |||
| versionFile: 'package.json', | |||
|
|
|||
| commitHashLength: function() { | |||
| if (this.type === 'git-commit') { | |||
There was a problem hiding this comment.
This was added to ensure that we are not breaking the current behavior even though it is inconsistent.
|
Is there any plan to merge this? We've been bitten by this with regards to the SHAs for SourceMaps not matching. |
|
Is there any hope at all that this PR will get merged one day? Otherwise I am sadly finding myself on a highway to using forks of almost the entire ember-cli-deploy pipeline, because of little inconsistencies like this one. Any thing I can do to help getting this merged? |
|
Yes, let's get it merged. I will work on this later today. |
|
@st-h and anyone else who would like to help: I've released https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/releases/tag/v2.0.0-beta.0. I would like a few people to test it before I make it 2.0.0 final. |
|
Awesome. Thanks so much. Will report back. |
What Changed & Why
This allows the length of the commit hash that is used to construct the
revisionKeybe configured. This applies to thegit-commit,git-tag-commit, andversion-commitdata generator types.Example usage:
This example would cause the entire commit hash to be used as the
revisionKey.Related issues
Fixes #22
PR Checklist
Prefix documentation-only commits with [DOC]People
@Bockit