Make ember-load-initializers an addon #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! Thanks for working on it! Can you add a shim for the old module ('ember/load-initializers')? The ember-resolver addon did something similar for reference (vendor file + app.import I think). |
| name: 'ember-load-initializers', | ||
|
|
||
| included: function() { | ||
| this._super(...arguments); |
There was a problem hiding this comment.
This executes in Node, where we may not have spread arguments.
I'd suggest using this._super.apply(this, arguments); instead.
josemarluedke
force-pushed
the
addonfy
branch
from
30990b5 to
cf888d4
Compare
|
@rwjblue Just added the shims. We should be good now. |
josemarluedke
force-pushed
the
addonfy
branch
from
cf888d4 to
2dfb377
Compare
rwjblue
added a commit
that referenced
this pull request
Feb 3, 2016
Make ember-load-initializers an addon
|
Thank you @josemarluedke!!! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there.
This is an attempt to migrate to addon. Not sure if everything is in the best way to do things, but I'm looking for some feedbacks and I will fix it. In my tests, it works fine with changes required in ember-cli (PR coming as well).
Helps with ember-cli/ember-cli#4546.