Add RFCs to ember-data 5.x deprecations (for which I could find the RFCs) #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kategengler
force-pushed
the
kg-add-rfc-references
branch
from
9398ea8 to
4436542
Compare
kategengler
commented
May 1, 2025
| @@ -28,4 +29,4 @@ If you are unsure whether your Store class uses EmberObject APIs, set this | |||
| config and uses of those APIs will throw exceptions. The most common API that | |||
| may have been used is `Store.extend({...`. | |||
|
|
|||
| This deprecation is from RFC [#1026](https://rfcs.emberjs.com/id/1026-ember-data-deprecate-store-extends-ember-object). | |||
| This deprecation was introduced in RFC [#1026](https://rfcs.emberjs.com/id/1026-ember-data-deprecate-store-extends-ember-object). | |||
There was a problem hiding this comment.
I think we should consider adding this bit to the template in the future, conditional on the rfc field existing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.