Fix lint-fixing with typescript-eslint 8 #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `sourceFile` objects that `typescript` manages, `gts` files end up with an `impliedNodeFormat` of `undefined` and `mts` files end up with an `impliedNodeFormat` of `99`. The buckets that `typescript` uses to cache the source files are keyed by their format, so when we run this syncing logic on an existing `mts` file we were overwriting its `impliedNodeFormat` and setting it to `undefined`. Perhaps something changed in `typescript-eslint@8` to take advantage of more caching or program reuse, not sure, but the result is that overwriting the `impliedNodeFormat` of the `mts` files that correspond to un-fixed `gts` files causes the error in ember-tooling#119. Adding it to the list of fields to preserve fixes it in all the cases I've run.
NullVoxPopuli
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
sourceFileobjects thattypescriptmanages,gtsfiles end up with animpliedNodeFormatofundefinedandmtsfiles end up with animpliedNodeFormatof99. The buckets thattypescriptuses to cache the source files are keyed by their format, so when we run this syncing logic on an existingmtsfile we were overwriting itsimpliedNodeFormatand setting it toundefined. Perhaps something changed intypescript-eslint@8to take advantage of more caching or program reuse, not sure, but the result is that overwriting theimpliedNodeFormatof themtsfiles that correspond to un-fixedgtsfiles causes the error in #119. Adding it to the list of fields to preserve fixes it in all the cases I've run.Fixes #119