remove code that was using an non-existent export #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid runtime error if that code was ever to be hit
SergeAstapov
approved these changes
Jul 12, 2023
|
the test/type failures have nothing to do with this pr, what will it take to land these changes? |
|
@SergeAstapov any updates on this? |
davidtaylorhq
added a commit
to chancancode/discourse
that referenced
this pull request
Sep 6, 2023
This turns 'missing export' warnings into errors, and will help us catch them in CI. This commit also includes fixes for two such problems: - Updates incorrect import in auth-complete.js - Patches legacy-built-in-components with the change from emberjs/ember-legacy-built-in-components#21 (merged but not yet released)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid runtime error if that code was ever to be hit
since the commented out code this used to reference is using global lookups which have been deprecated, this seems like the correct change to make
closes #18