-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to V2 Addon #87
base: master
Are you sure you want to change the base?
Conversation
Ran `pnpx ember-cli@latest addon @ember/render-modifiers -b @embroider/addon-blueprint --pnpm --skip-install --skip-git --typescript --addon-location=ember-render-modifiers` and created everything from scratch then copied in modifiers, tests, and the PNPM version setting from ci.yml
Awesome, thank you for working on this!
v2 addons are configured to use the
Most official Ember projects now use release-plan, which can only be setup by maintainers AFAIK, so I don't think you need to do anything release related in this conversion PR. |
{ src: '../../README.md', dest: '.' }, | ||
{ src: '../../LICENSE.md', dest: '.' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these files are stored in the parent folder?
{ src: '../../README.md', dest: '.' }, | |
{ src: '../../LICENSE.md', dest: '.' }, | |
{ src: '../README.md', dest: '.' }, | |
{ src: '../LICENSE.md', dest: '.' }, |
"webpack": "^5.95.0" | ||
}, | ||
"peerDependencies": { | ||
"@glint/template": "^1.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This peerDep is probably still needed (together with the peerDependenciesMeta config).
}, | ||
"dependencies": { | ||
"@embroider/addon-shim": "^1.8.9", | ||
"@embroider/util": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this dep needed? I don't think it's used, but hard to say for sure from the web UI 😅.
This comment was marked as outdated.
This comment was marked as outdated.
"@tsconfig/ember": "^3.0.8", | ||
"babel-plugin-ember-template-compilation": "^2.2.5", | ||
"concurrently": "^9.0.1", | ||
"ember-source": "^5.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the reason why v5.12 is installed and the Embroider scenario fails. I think you can fix it by making it match the test-app version.
@Windvis thanks for the review. I think, but haven't gone back to confirm yet, that all of these issues are right off the embroider addon blueprint. My feeling is we should always stick as closely to the blueprint as possible to make updating easy. |
Ran
pnpx ember-cli@latest addon @ember/render-modifiers -b @embroider/addon-blueprint --pnpm --skip-install --skip-git --typescript --addon-location=ember-render-modifiers
and created everything from scratch then copied in modifiers, tests, and the PNPM version setting from ci.ymlSuperseeds #66
Todo: