Skip to content

Audit all uses of @no_wasm_backend and remove it #12335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbc100 opened this issue Sep 24, 2020 · 2 comments · Fixed by #16747
Closed

Audit all uses of @no_wasm_backend and remove it #12335

sbc100 opened this issue Sep 24, 2020 · 2 comments · Fixed by #16747
Assignees
@sbc100

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Sep 24, 2020

There are bunch of tests still using this decorator. They need to fixed, remove, or disabled for some other reason.
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 24, 2020

Part of #11860

sbc100 added a commit that referenced this issue Sep 25, 2020
@sbc100
tests: Removal of @no_wasm_backend, part 1. NFC
6114f00 
This change removes the use of this decorator from the other
and sanity test suites.

Some tests simply worked, some make no sense with wasm backend and
a couple are tests we would like revive once day (related to ctor
evaluation and ctor elimiation).

See: #12335
@sbc100 sbc100 mentioned this issue Sep 25, 2020
Merged
sbc100 added a commit that referenced this issue Sep 25, 2020
@sbc100
tests: Removal of @no_wasm_backend, part 1
ebbcc40 
This change removes the use of this decorator from the other
and sanity test suites.

Some tests simply worked, some make no sense with wasm backend and
a couple are tests we would like revive once day (related to ctor
evaluation and ctor elimiation).

There was one test for which I implemented the feature which was
to ingnore multiple copies of the same .so file on the link line.
This improves the fake shared library support a little and was
a feature of fastcomp.

See: #12335
sbc100 added a commit that referenced this issue Sep 25, 2020
@sbc100
tests: Removal of @no_wasm_backend, part 1
9520019 
This change removes the use of this decorator from the other
and sanity test suites.

Some tests simply worked, some make no sense with wasm backend and
a couple are tests we would like revive once day (related to ctor
evaluation and ctor elimiation).

There was one test for which I implemented the feature which was
to ingnore multiple copies of the same .so file on the link line.
This improves the fake shared library support a little and was
a feature of fastcomp.

See: #12335
sbc100 added a commit that referenced this issue Sep 28, 2020
@sbc100
tests: Removal of @no_wasm_backend, part 1
f87f533 
This change removes the use of this decorator from the other
and sanity test suites.

Some tests simply worked, some make no sense with wasm backend and
a couple are tests we would like revive once day (related to ctor
evaluation and ctor elimiation).

There was one test for which I implemented the feature which was
to ingnore multiple copies of the same .so file on the link line.
This improves the fake shared library support a little and was
a feature of fastcomp.

See: #12335
sbc100 added a commit that referenced this issue Sep 28, 2020
@sbc100
tests: Removal of @no_wasm_backend, part 1 (#12338)
d021a98 
This change removes the use of this decorator from the other
and sanity test suites.

Some tests simply worked, some make no sense with wasm backend and
a couple are tests we would like revive once day (related to ctor
evaluation and ctor elimiation).

There was one test for which I implemented the feature which was
to ingnore multiple copies of the same .so file on the link line.
This improves the fake shared library support a little and was
a feature of fastcomp.

See: #12335
sbc100 added a commit that referenced this issue Oct 7, 2020
@sbc100
test_core.py: remove @no_wasm decorator
4e1fb00 
See: #12335
@sbc100 sbc100 mentioned this issue Oct 7, 2020
Merged
sbc100 added a commit that referenced this issue Oct 8, 2020
@sbc100
test_core.py: remove @no_wasm decorator
5555065 
See: #12335
sbc100 added a commit that referenced this issue Oct 8, 2020
@sbc100
test_core.py: remove @no_wasm decorator (#12466)
4f8a0be 
See: #12335
@stale
Copy link

stale bot commented Sep 26, 2021

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Sep 26, 2021
@stale stale bot closed this as completed Apr 17, 2022
@sbc100 sbc100 reopened this Apr 18, 2022
@stale stale bot removed the wontfix label Apr 18, 2022
@sbc100 sbc100 self-assigned this Apr 18, 2022
sbc100 added a commit that referenced this issue Apr 18, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
a97708d 
Fixes: #12335
@sbc100 sbc100 mentioned this issue Apr 18, 2022
Merged
sbc100 added a commit that referenced this issue Apr 18, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
d5b1f15 
Fixes: #12335
sbc100 added a commit that referenced this issue Apr 18, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
ca3f5a7 
Fixes: #12335
sbc100 added a commit that referenced this issue Apr 18, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
a76ab47 
Fixes: #12335
sbc100 added a commit that referenced this issue Apr 18, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
a757585 
Fixes: #12335
sbc100 added a commit that referenced this issue Apr 19, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
4b6800c 
Fixes: #12335
sbc100 added a commit that referenced this issue Apr 20, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
d32796b 
Fixes: #12335
sbc100 added a commit that referenced this issue Apr 20, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC
cf990a6 
Fixes: #12335
sbc100 added a commit that referenced this issue Apr 20, 2022
@sbc100
Remove @no_wasm_backend test decorator. NFC (#16747)
659c041 
Fixes: #12335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbc100 sbc100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove @no_wasm_backend test decorator. NFC emscripten-core/emscripten
1 participant
@sbc100