You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The JS assert function is no longer available in release builds when -sSTRICT is used. This should only affect users with custom JS library code which doesn't use #if ASSERTIONS guards around their assert calls.
webidl_binder.py contains several asserts which aren't guarded. Incomplete list:
Surround asserts in a CHECKS == 'ALL' conditional, similar to other asserts.
Allows a workaround to #21198, when a user builds with: export IDL_CHECKS="FAST"
@sbc100 Ah I didn't see that, and added a PR of my own.
Not sure which approach is better, but I like that you're will catch any more asserts added in the future.
As of Emscripten 3.1.48:
webidl_binder.py contains several
assert
s which aren't guarded. Incomplete list:emscripten/tools/webidl_binder.py
Line 217 in ce5114b
emscripten/tools/webidl_binder.py
Line 222 in ce5114b
emscripten/tools/webidl_binder.py
Line 229 in ce5114b
The text was updated successfully, but these errors were encountered: