Remove fastcomp-only EMULATED_FUNCTION_POINTERS setting #11864
Conversation
| @@ -1795,19 +1785,6 @@ def test_bigarray(self): | |||
| def test_mod_globalstruct(self): | |||
| self.do_run_in_out_file_test('tests', 'core', 'test_mod_globalstruct') | |||
|
|
|||
| @no_wasm_backend('long doubles are f128s in wasm backend') | |||
| def test_pystruct(self): | |||
There was a problem hiding this comment.
I wonder if this test is still useful? It looks like it was disabled not because EMULATED_FUNCTION_POINTERS was missing but because of fp128.
There was a problem hiding this comment.
I think probably not... it just has some interesting structs in it, taken from python. We test equally interesting things in other places, and it's more of a clang-level feature anyhow. The interesting part of the test was the relocatable + emulated function pointers part which is removed, so I removed the whole test.
tests/test_core.py
Outdated
| @@ -6012,20 +5989,9 @@ def count_relocations(): | |||
| num_relocs = relocs.count('\n') | |||
| return relocs, num_relocs | |||
There was a problem hiding this comment.
Huh.. this function looks completely unused both before and after this change...
| # success! | ||
| self.assertContained('Hello, world.', output) | ||
| for relocatable in [0, 1]: | ||
| for wasm in [0, 1]: |
|
Yeah, it can be confusing - emulated function pointers is not the same as emulated function pointer casts. The latter is necessary for python and we have a binaryen pass for it, yes. Getting rid of this setting will remove that confusion! |
|
Lets try to reference #11860 in all the cleanups. |
(some changes best viewed without whitespace)