Skip to content

library_async.js cleanup #11867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2020
Merged

library_async.js cleanup #11867

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aab20d7
Minor library_async.js cleanup
Akaricchi Aug 12, 2020
3b4caec
Asyncify: remove stub functions, require -s ASYNCIFY if linking to li…
Akaricchi Aug 12, 2020
7b8a4fc
Revert "Asyncify: remove stub functions, require -s ASYNCIFY if linki…
Akaricchi Aug 12, 2020
4924d68
async: remove old coroutine API stubs
Akaricchi Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 7 additions & 24 deletions src/library_async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ mergeInto(LibraryManager.library, {
// We must first unwind, so things are spilled to the stack. We
// can resume right after unwinding, no need for a timeout.
Asyncify.afterUnwind = function() {
{{{ makeDynCall('vii') }}}(func, Asyncify.currData + 8, HEAP32[Asyncify.currData >> 2]);
var stackBegin = Asyncify.currData + {{{ C_STRUCTS.asyncify_data_s.__size__ }}};
var stackEnd = HEAP32[Asyncify.currData >> 2];
{{{ makeDynCall('vii') }}}(func, stackBegin, stackEnd);
wakeUp();
};
});
Expand Down Expand Up @@ -408,7 +410,7 @@ mergeInto(LibraryManager.library, {
var userData = {{{ makeGetValue('newFiber', C_STRUCTS.emscripten_fiber_s.user_data, 'i32') }}};
{{{ makeDynCall('vi') }}}(entryPoint, userData);
} else {
var asyncifyData = newFiber + 20;
var asyncifyData = newFiber + {{{ C_STRUCTS.emscripten_fiber_s.asyncify_data }}};
Asyncify.currData = asyncifyData;

#if ASYNCIFY_DEBUG
Expand Down Expand Up @@ -487,36 +489,17 @@ mergeInto(LibraryManager.library, {
Asyncify.currData = null;
}
},

emscripten_coroutine_create: function() {
throw 'emscripten_coroutine_create has been removed. Please use the Fibers API';
},
emscripten_coroutine_next: function() {
throw 'emscripten_coroutine_next has been removed. Please use the Fibers API';
},
emscripten_yield: function() {
throw 'emscripten_yield has been removed. Please use the Fibers API';
},
#else // ASYNCIFY
emscripten_sleep: function() {
throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_sleep';
},
emscripten_coroutine_create: function() {
throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_coroutine_create';
},
emscripten_coroutine_next: function() {
throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_coroutine_next';
},
emscripten_yield: function() {
throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_yield';
},
emscripten_wget: function(url, file) {
emscripten_wget: function() {
throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_wget';
},
emscripten_wget_data: function(url, file) {
emscripten_wget_data: function() {
throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_wget_data';
},
emscripten_scan_registers: function(url, file) {
emscripten_scan_registers: function() {
throw 'Please compile your program with async support in order to use asynchronous operations like emscripten_scan_registers';
},
emscripten_fiber_init: function() {
Expand Down