Remove fastcomp-only SEPARATE_ASM option. See #11860 #11869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Aug 12, 2020
| @@ -3031,9 +2995,6 @@ def consume_arg(): | |||
| options.valid_abspaths.append(newargs[i + 1]) | |||
| newargs[i] = '' | |||
| newargs[i + 1] = '' | |||
| elif newargs[i] == '--separate-asm': | |||
There was a problem hiding this comment.
Keep this around and issue an appropriate error?
There was a problem hiding this comment.
Ah, good point, this PR needs to do that to be NFC, as we errored before. Fixing...
| @@ -1080,10 +1070,6 @@ var ASM_JS = 1; | |||
| // [fastcomp-only] | |||
| var FINALIZE_ASM_JS = 1; | |||
|
|
|||
| // see emcc --separate-asm | |||
| // [fastcomp-only] | |||
| var SEPARATE_ASM = 0; | |||
There was a problem hiding this comment.
Add these 2 to LEGACY_SETTINGS.
No use. It's always errored with the wasm backend (and fastcomp with wasm). It's only ever been asm.js specific. (I can in theory see a need for such a feature for wasm2js though. If that comes up we can revive this, or maybe find a better way.) |
sbc100
added a commit
that referenced
this pull request
Jan 13, 2022
Last reference to this file was removed in #11869.
sbc100
added a commit
that referenced
this pull request
Jan 13, 2022
Last reference to this file was removed in #11869.
sbc100
added a commit
that referenced
this pull request
Jan 13, 2022
tests/atomicrmw_i64.ll: Usage was removed in #13244 tests/encapsulated_asmjs_page_load.html: Usage was removed in #11869 tests/core/test_ptrtoint.out: Usage removed in #6850 tests/core/test_lower_intrinsics.out: Usage removed in #12807 tests/core/test_llvm_intrinsics.out: Usage removed in #12807 tests/qsort/benchmark.cpp: Has never been used.
sbc100
added a commit
that referenced
this pull request
Jan 13, 2022
tests/atomicrmw_i64.ll: Usage was removed in #13244 tests/encapsulated_asmjs_page_load.html: Usage was removed in #11869 tests/core/test_ptrtoint.out: Usage removed in #6850 tests/core/test_lower_intrinsics.out: Usage removed in #12807 tests/core/test_llvm_intrinsics.out: Usage removed in #12807 tests/qsort/benchmark.cpp: Has never been used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.