Fix a dependency between libc++ and malloc/free #12259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I the long run I think we should just move mmap/munmap into native code. I looked at doing it while ago by just using the same code that wasi-libc uses... but the simple approach there don't honor the page alignment requirement. |
sbc100
approved these changes
Sep 17, 2020
|
#12260 landed so we don't need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using any locale stuff (
std::__2::ios_base::getloc() constis what is usedin practice) ends up including a lot of various code, including mmap/munmap
which indirectly call malloc/free from JS. This broke when we stopped
including malloc/free by default in #12213. It broke closure, which errors on
this - I'm not sure it's possible to actually get mmap/munmap to actually be
used in that code path.
Adds a test that breaks without the fix.
Sadly this shows the fragility of this approach - we have lots of malloc/free
uses in our JS, and quite a lot of code paths from system libs to there,
which is how this one was missed. OTOH, in practice any non-trivial
program tends to include malloc/free anyhow, which is why we haven't
gotten bug reports I think (I noticed this particular issue by chance when
looking at random_device).