Update to latest xcode version #12332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xcode version is only really used when we want to do native clang build, and we recent ran into issues of compatiblity between our clang-12 binary and linker that is part of xcode 9.0.0. We were seeing clang pass `-platform_version` to the linker which is not a supported linker flag in xcode 9.0.0. I'm not sure exactly how this ever worked to why it broke in the last couple of days. Fixes: #12331
|
On further investigation it looks like an upstream llvm change that broke us. Tracking it down now. |
kripken
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xcode version is only really used when we want to do native
clang build, and we recent ran into issues of compatiblity between
our clang-12 binary and linker that is part of xcode 9.0.0.
We were seeing clang pass
-platform_versionto the linker whichis not a supported linker flag in xcode 9.0.0.
I'm not sure exactly how this ever worked to why it broke in the last
couple of days.
Fixes: #12331