Skip to content

Remove no_wasm_backend usage from test_core.py. NFC. #12807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Remove no_wasm_backend usage from test_core.py. NFC. #12807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions tests/core/test_intentional_fault.c
View file
Open in desktop

This file was deleted.

198 changes: 0 additions & 198 deletions tests/core/test_llvm_intrinsics.cpp
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions tests/core/test_lower_intrinsics.c
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion tests/core/test_varargs_multi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,18 @@ void print_vararg(int n, va_list v) {
void multi_vararg(int n, ...) {
va_list v;

printf("part1:\n");
va_start(v, n);
print_vararg(n, v);
print_vararg(n, v); // the value of v is undefined for this call
va_end(v);

printf("part2:\n");
va_start(v, n);
print_vararg(n, v);
printf("part3:\n");
print_vararg(n, v); // the value of v is undefined for this call
va_end(v);

}

int main() {
Expand Down
7 changes: 5 additions & 2 deletions tests/core/test_varargs_multi.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
part1:
8, 6, 4, 2, 0
part2:
8, 6, 4, 2, 0
part3:
8, 6, 4, 2, 0
1, 3, 5, 7, 9
8, 6, 4, 2, 0
8 changes: 0 additions & 8 deletions tests/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,6 @@ def decorated(self, *args, **kwargs):
return decorated


# Today we only support the wasm backend so any tests that is disabled under the llvm
# backend is always disabled.
# TODO(sbc): Investigate all tests with this decorator and either fix of remove the test.
def no_wasm_backend(note=''):
assert not callable(note)
return unittest.skip(note)


def disabled(note=''):
assert not callable(note)
return unittest.skip(note)
Expand Down
10 changes: 9 additions & 1 deletion tests/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from urllib.request import urlopen

from runner import BrowserCore, RunnerCore, path_from_root, has_browser, EMTEST_BROWSER
from runner import no_wasm_backend, create_test_file, parameterized, ensure_dir
from runner import create_test_file, parameterized, ensure_dir
from tools import building
from tools import shared
from tools import system_libs
Expand Down Expand Up @@ -126,6 +126,14 @@ def decorated(self, *args, **kwargs):
return decorated


# Today we only support the wasm backend so any tests that is disabled under the llvm
# backend is always disabled.
# TODO(sbc): Investigate all tests with this decorator and either fix of remove the test.
def no_wasm_backend(note=''):
assert not callable(note)
return unittest.skip(note)


requires_graphics_hardware = unittest.skipIf(os.getenv('EMTEST_LACKS_GRAPHICS_HARDWARE'), "This test requires graphics hardware")
requires_sound_hardware = unittest.skipIf(os.getenv('EMTEST_LACKS_SOUND_HARDWARE'), "This test requires sound hardware")
requires_sync_compilation = unittest.skipIf(is_chrome(), "This test requires synchronous compilation, which does not work in Chrome (except for tiny wasms)")
Expand Down
Loading