Refactor the threading.h C proxying API #15681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step toward decoupling the logic for proxying work to threads from the logic for creation and dispatch of `em_queued_call` objects, which couple a dynamically typed function pointer with its arguments. Decoupling these pieces will allow for more general proxying that is not required to use the `em_queued_call` mechanism and will simplify the code.
Refactor the C proxying API to separate the proxying logic from the logic for creation and use of em_queued_call objects. Also provide a richer and more orthogonal set of `emscripten_dispatch_to_thread_*` variants: - emscripten_dispatch_to_thread - send a task to a thread for asynchronous execution. - emscripten_dispatch_to_thread_async - same, but schedule for asynchronous execution even if already on the target thread. - emscripten_dispatch_to_thread_sync - wait for the dispatched function to finish before returning. - emscripten_dispatch_to_thread_async_as_sync - wait for the dispatched task to be marked finished via an explicit call to `emscripten_async_as_sync_finish`. Each of these functions comes in a lower-level `*_ptr` variant that accepts function pointers and void* arguments as well as higher-level variants that construct and dispatch `em_queued_call` objects. Each variant builds incrementally on some other variant, all bottoming out at `emscripten_dispatch_to_thread_ptr`, so it should be easy to incrementally understand how each layer works. The other miscellaneous proxying functions exposed in threading.h are now implemented in terms of the most appropriate `emscripten_dispatch_to_thread*` variant as well.
This was referenced Dec 1, 2021
kripken
reviewed
Dec 1, 2021
|
I can split out a few things, yes. Others would be more difficult to split out because they are now implemented in terms of the new functions. I just reopened #15648 as a first step. I'll make another preliminary PR or two. |
- Rebaseline the failing metadce test - Change the expected return value of `emscripten_dispatch_to_thread`. It now returns 1 if the call was successfully scheduled, not just if it was synchronously executed.
|
Just added a commit to fix some tests. First, the code size increased and the exports changed in the metadce test. Second, I'm still investigating the posixtest.test_pthread_setcanceltype_1_1 failure. |
|
Another preliminary NFC change: #15686 |
|
Another smaller change, this one not NFC: #15690 |
|
Another NFC change: #15691. |
ethanalee
added a commit
that referenced
this pull request
Dec 3, 2021
|
Closing this in favor of the plan in #15705 (comment). |
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
Relevant Issue: emscripten-core#15041 Introduce new proxied backend structure for the new file system. Proxying will be refactored soon using on this PR: emscripten-core#15681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the C proxying API to separate the proxying logic from the logic for
creation and use of em_queued_call objects. Also provide a richer and more
orthogonal set of
emscripten_dispatch_to_thread_*variants:emscripten_dispatch_to_thread - send a task to a thread for asynchronous
execution.
emscripten_dispatch_to_thread_async - same, but schedule for asynchronous
execution even if already on the target thread.
emscripten_dispatch_to_thread_sync - wait for the dispatched function to
finish before returning.
emscripten_dispatch_to_thread_async_as_sync - wait for the dispatched task to
be marked finished via an explicit call to
emscripten_async_as_sync_finish.Each of these functions comes in a lower-level
*_ptrvariant that acceptsfunction pointers and void* arguments as well as higher-level variants that
construct and dispatch
em_queued_callobjects.Each variant builds incrementally on some other variant, all bottoming out at
emscripten_dispatch_to_thread_ptr, so it should be easy to incrementallyunderstand how each layer works. The other miscellaneous proxying functions
exposed in threading.h are now implemented in terms of the most appropriate
emscripten_dispatch_to_thread*variant as well.