[WasmFS] Implement fdatasync
#16675
Merged
[WasmFS] Implement fdatasync
#16675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an alias for `__wasi_fd_sync` (i.e. `fsync`). This flushes data more conservatively than necessary, but it's not worth maintaining a separate code path to avoid flushing file metadata right now.
kripken
reviewed
Apr 8, 2022
There was a problem hiding this comment.
lgtm % testing
Is the new test because the existing test that covers this (unistd/misc.c) also tests other stuff we don't pass? Or because we want more fine-grained testing?
The existing test also checks for an error so if we want a new test we should add that here too.
If this test is temporary please add a TODO to remove it. If it's meant to be permanent then let's remove the relevant lines from the existing test?
|
Oh, the new test is not enough to replace the old because the new one is wasmfs-only? |
|
I'll add a TODO to remove this test in favor of unistd/misc.c and make it WasmFS-only since there's no reason to run this test on the classic FS. |
|
Merging given previous LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alias for
__wasi_fd_sync(i.e.fsync). This flushes data moreconservatively than necessary, but it's not worth maintaining a separate code
path to avoid flushing file metadata right now.
Resolves #16672.