Skip to content

Move JS version of printf/puts to library_bootstrap #16961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 17, 2022

These functions are only needed/used when generating struct info.
Contrary to the comment we have no tests that use these functions.

@sbc100 sbc100 requested a review from kripken May 17, 2022 17:02
@sbc100 sbc100 force-pushed the formatString_helpers branch from cf839ce to 39fd681 Compare May 17, 2022 17:54
@sbc100 sbc100 changed the title Move JS version of strlen/printf/puts to library_bootstrap Move JS version of printf/puts to library_bootstrap May 17, 2022
@sbc100 sbc100 force-pushed the formatString_helpers branch from 39fd681 to 398e08f Compare May 17, 2022 18:02
@sbc100 sbc100 enabled auto-merge (squash) May 17, 2022 18:15
These functions are only needed/used when generating struct info.
Contrary to the comment we have not tests that use these functions.
@sbc100 sbc100 force-pushed the formatString_helpers branch from 398e08f to d12945c Compare May 17, 2022 18:35
@sbc100 sbc100 merged commit 103a218 into main May 17, 2022
@sbc100 sbc100 deleted the formatString_helpers branch May 17, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants