cmake: Fix references to OSX / OS X. NFC #18902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Mar 5, 2023
cmake/Modules/CheckTypeSize.cmake
Outdated
| @@ -30,7 +30,7 @@ | |||
| # the macro undefined if the type does not exist. | |||
| # | |||
| # The variable "${VARIABLE}" may be "0" when CMAKE_OSX_ARCHITECTURES has | |||
| # multiple architectures for building OS X universal binaries. This | |||
There was a problem hiding this comment.
Because this file is essentially copied from upstream cmake I think its best to leave it unpatched if thats OK? It makes copariing with and updating from upstream easier if we minimize changes.
|
Do you have time to update and land this? |
Use macOS instead.
waywardmonkeys
force-pushed
the
cmake-osx-references
branch
from
e68bae7 to
183eb2c
Compare
|
@sbc100 Sorry about the 10 month delay ... but I've updated this per your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use macOS instead.