[emval] Update the co_await operator and promise_type for val to make it moveable rather than just copy. #21432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
co_await
operator andpromise_type
forval
to make it moveable rather than just copy.This removes C++ -> JS incref/decref calls for lifetime management. For test_embind_val_coro this removes all calls to incref, except for the two added explicitly to test that code-path.
I believe the change to
get_return_object()
to move the JS promiseval
is safe since it is not used again and part of the state owned byawaiter
, and discussion here emphasizes that such a return type should likely be move-only.Still permits copy of
val
for aco_await
if the promise is retained, as covered by new test code.