Avoid node TimeoutNegativeWarning in emscripten_set_timeout_loop #23722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_TimeoutNegativeWarning
branch
from
e884357 to
e016b4e
Compare
sbc100
changed the title
kripken
reviewed
Feb 24, 2025
sbc100
force-pushed
the
fix_TimeoutNegativeWarning
branch
from
e016b4e to
aefa478
Compare
kripken
approved these changes
Feb 24, 2025
This restores the two different paths for calculating the remaining milliseconds which was removed in emscripten-core#12122. Inspired by emscripten-core#23716
sbc100
force-pushed
the
fix_TimeoutNegativeWarning
branch
from
aefa478 to
afe0398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the two different paths for calculating the remaining milliseconds which was removed in #12122.
Inspired by #23716