-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Make 'instantiateWasm' callback resolve the result return from 'recei… #23781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
feabf26
Make 'instantiateWasm' callback resolve the result return from 'recei…
gogogoghost 532dff3
Update 'test_instantiate_wasm' to cover when ASYNCIFY and EXPORT_ES6 …
gogogoghost 9d91469
Merge branch 'main' into main
gogogoghost 4ddca57
Remove '-sEXPORT_ES6' from 'test_instantiate_wasm' and add a comment
gogogoghost 9528492
Merge branch 'main' into main
gogogoghost fe1b791
Remove unnecessary parameters and calls
gogogoghost b4ad166
Merge branch 'main' of github.com:gogogoghost/emscripten
gogogoghost a73404f
Remove unnecessary output check
gogogoghost 900d8d1
Merge branch 'main' into main
gogogoghost 6775dbf
Merge branch 'emscripten-core:main' into main
gogogoghost 06de16e
Merge branch 'main' into main
gogogoghost c76d934
Fix test browser.test_manual_wasm_instantiate
gogogoghost 698f5ac
Remove useless parameter
gogogoghost 3c56f4f
Restore test browser.test_manual_wasm_instantiate and allow test_manu…
gogogoghost 91083ea
Merge branch 'main' into main
gogogoghost fea8cf7
Merge branch 'main' of github.com:gogogoghost/emscripten
gogogoghost e12cf37
Add -DASYNCIFY_ENABLED to distinguish ASYNCIFY
gogogoghost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes in this file necessary? It looks like you could revert this file probably.