Skip to content

Deprecate MEM_INIT_METHOD 2 #5401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ var MEM_INIT_METHOD = 0; // How to represent the initial memory content.
// 1: create a *.mem file containing the binary data of the initial memory;
// use the --memory-init-file command line switch to select this method
// 2: embed a string literal representing that initial memory data
// XXX this is known to have bugs on windows, see https://github.com/kripken/emscripten/pull/3326
// XXX this is known to have bugs on windows, see https://github.com/kripken/emscripten/pull/3326;
// due to mode 0's recent upgrade to space-efficient base64 encoding
// and the long-standing issues with this mode, this mode is now
// deprecated in favor of mode 0
var TOTAL_STACK = 5*1024*1024; // The total stack size. There is no way to enlarge the stack, so this
// value must be large enough for the program's requirements. If
// assertions are on, we will assert on not exceeding this, otherwise,
Expand Down