Skip to content

Change an assertion to an error when the emterpreter data is missing #5653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2017

Conversation

curiousdannii
Copy link
Contributor

When the emterpreter data is missing there is an assertion, but this disappears at higher optimisation levels. Change it to throw an error so that the check is always there, rather than a more cryptic error down the line when the variable is used.

Uncovered as part of #5330.

@kripken kripken merged commit 313f0d0 into emscripten-core:incoming Oct 11, 2017
@kripken
Copy link
Member

kripken commented Oct 11, 2017

Thanks!

@curiousdannii curiousdannii deleted the patch-1 branch October 12, 2017 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants