Multithreading 18/N: drop_pthread_entrypoint_sig_hack #6085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
juj
force-pushed
the
drop_pthread_entrypoint_sig_hack
branch
from
b3ec348 to
08f3fd7
Compare
…ce it is no longer functional to run threads unit tests, instead rely on -s EMULATE_FUNCTION_POINTER_CASTS=1 as a better emulation mechanism
juj
force-pushed
the
drop_pthread_entrypoint_sig_hack
branch
from
08f3fd7 to
ae69137
Compare
|
Hmm, the actual changes went into the tree in #6084, and this amounted to only whitespace changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the pthread entry point callback signature detection hack, since it is no longer functional to run threads unit tests, instead rely on -s EMULATE_FUNCTION_POINTER_CASTS=1 as a better emulation mechanism