Skip to content

Conditionally use @nodejs_host or @nodejs #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conditionally use @nodejs_host or @nodejs #1035

merged 1 commit into from
Apr 14, 2022

Conversation

jfirebaugh
Copy link
Contributor

Which of these exists depends on the version of rules_nodejs being used.

Fixes #1020.

@walkingeyerobot walkingeyerobot self-requested a review April 14, 2022 19:22
@walkingeyerobot walkingeyerobot merged commit e23aac7 into emscripten-core:main Apr 14, 2022
@walkingeyerobot
Copy link
Collaborator

Thanks very much!

@jfirebaugh jfirebaugh deleted the jfirebaugh/fix-1020 branch April 14, 2022 20:14
@jfirebaugh
Copy link
Contributor Author

Well, now that I'm getting around to trying this in my own project, which uses rules_nodejs 5.2.0, it looks like it does not work. I get the same "no such package '@nodejs//'" error. I guess existing_rule does not work like I thought it did in this context, and existing_rule("@nodejs_host//:node_files") always returns false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walkingeyerobot walkingeyerobot walkingeyerobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Bazel @nodejs repo to @nodejs_host
2 participants
@jfirebaugh @walkingeyerobot