1.39.16 #503
1.39.16 #503
Conversation
| # The emsdk ships all system libraries so we don't expect to see any | ||
| # cache population unless we explicly --clear-cache. | ||
| test_build('', expected=False) | ||
| check_call(emcc + ' --clear-cache') |
There was a problem hiding this comment.
this is maybe excessive - CI here will wait on building all of libc. maybe just delete say libdlmalloc?
There was a problem hiding this comment.
The problem is that each version of SDK now has it own cache... so I'd need to figure out where each libc is. For the upstream SDK I know this because of EM_CACHE, but for fastcomp I'd need to derive the cache directory somehow.
There was a problem hiding this comment.
Ok, how about removing fastcomp cache testing then?
There was a problem hiding this comment.
Sure.. although building libc only takes less than a minute, no? Does it it matter on the emsdk CI?
There was a problem hiding this comment.
Not a big deal, yeah. But it's nice if emsdk CI is fast as we want to avoid anything landing on emscripten while we tag. lgtm either way though.
emscripten-releases-tags.txt
Outdated
| "releases": { | ||
| "1.39.16": "701922c0d4a47ad6bc39bd72f083813a71be4ea7", |
There was a problem hiding this comment.
more stuff landed in emscripten meanwhile, so we need to update this
No description provided.