Add host network for building image #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docker docs say this flag only works on linux. Is that the only place this is used? |
|
We shouldn't be running docker commands anywhere except on linux. |
|
sgtm then. |
|
@kripken, it's supported on windows as well in my version: Thx for merging ! |
vargaz
pushed a commit
to vargaz/emsdk
that referenced
this pull request
Nov 22, 2023
emscripten-core#514) * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230922.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23468.3 -> To Version 9.0.0-alpha.1.23472.1 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230922.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23468.3 -> To Version 9.0.0-alpha.1.23472.1 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230922.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23468.3 -> To Version 9.0.0-alpha.1.23472.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
--network hostIt's impossible to build images (might be some recent addition for docker engine, as I don't recall it was a case before)