Skip to content

Change base to Ubuntu 20.04.2 LTS (Focal Fossa). #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

MarkCallow
Copy link
Contributor

This is principally, for me at least, to be able to include a more up to date version of CMake. Focal has 3.16.3. The Debian Buster based image had CMake 3.13. Installing the most recent CMake from KitWare into that Docker image proved impossible because it had a dependency on a version of libssl not in Buster.

test_dockerimage.sh runs successfully using the updated image as does my own project's build.

The size of this image is 1.67GB. The Buster-based image is 1.59GB.

Note that I have left intact all the explicit package installs as I did not want to spend time determining which of them may be installed by default in Focal.

After you merge this PR, how can I determine when the emscripten/emsdk image at docker.com has been updated?

@sbc100
Copy link
Collaborator

sbc100 commented Mar 8, 2021

Can you update the title to say "Ubuntu 20.04.2 LTS (Focal Fossa)" so its clear that its TLS and when its from?

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@sbc100 sbc100 requested review from kleisauke and trzecieu and removed request for kleisauke March 8, 2021 15:54
@MarkCallow MarkCallow changed the title Change base to Ubuntu Focal. Change base to Ubuntu 20.04.2 LTS (Focal Fossa). Mar 8, 2021
Copy link
Collaborator

@kleisauke kleisauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slightly increases the Docker image (with ~81MB), but otherwise this looks good to me. We may need to notify users who depend upon on the emscripten/emsdk:latest tag after this PR.

As for the size regression, since v2.0.5 it also increased a bit (with ~181MB) (as reported by @curiousdannii in #625 (comment) and #641 (comment)), so that would be more of a benefit if that is fixed.

After you merge this PR, how can I determine when the emscripten/emsdk image at docker.com has been updated?

It should be automatically updated/released whenever a new Emscripten version is released and the publish-docker-image CI job passes.

@sbc100 sbc100 merged commit cf2e337 into emscripten-core:master Mar 11, 2021
@MarkCallow MarkCallow deleted the focal_update branch May 23, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants