Skip to content

Update bazel readme #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2021
Merged

Update bazel readme #774

merged 4 commits into from
Mar 25, 2021

Conversation

celentes
Copy link
Contributor

No description provided.

@celentes
Copy link
Contributor Author

As promised, updates to readme post bazel setup changes.

@celentes
Copy link
Contributor Author

Here's a notion to think about:
Because bazel wants to download archives from a particular commit/tag, updating readme post changes has to go through a separate commit post-merge (as we don't know the url/hash/sha prior to merging).
The canonical alternative to that is point to the latest upstream release message like this. That way it's no longer part of the git/bazel conundrum, but the overhead is that it puts an extra step in release procedure.

Would that be acceptable? We can provide a script to generate the message.

@sbc100 sbc100 requested a review from walkingeyerobot March 25, 2021 15:09
@walkingeyerobot walkingeyerobot merged commit 459f7c1 into emscripten-core:master Mar 25, 2021
@walkingeyerobot
Copy link
Collaborator

Apologies, I didn't see the comment before reviewing / merging!

Pointing to the latest upstream release message would be fine.

@celentes
Copy link
Contributor Author

I'm gonna figure out a way to automate it later on.

radekdoulik referenced this pull request in dotnet/emsdk May 20, 2021
@celentes @radekdoulik
Update bazel readme (#774)
06f7f76 
* Update bazel/README.md

* Add deps instantiation to readme

* Add bazelrc explanations to readme

* Note the preferred way of using bazel emsdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walkingeyerobot walkingeyerobot walkingeyerobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celentes @walkingeyerobot