Mypy uvicorn #740
Closed
Mypy uvicorn #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-unions in wsgi, switched to all http there's no ws
… a mypy bug or limitation ?
Removed HeaderTypes
…ly just because it cant get scope has necessarily a "scheme" and "client" key
|
Hello! Why the MR was closed? |
|
too large to review mostly, but I added some parts incrementally for the lifespan for instance iirc so this could be revived but incrementally, PR welcome ! using the types here might be a good idea too django/asgiref#221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, on top of #739 for the tests etc
This is quite long....