feat: Implement JSValue::new_typed_array_with_bytes
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
feat-jsvalue-new-typed-array
branch
2 times, most recently
from
ab00e6e to
10d238f
Compare
This patch implements `JSValue::new_typed_array_with_bytes`. This method is marked as unsafe, because bytes aren't copied: they are borrowed mutably by JavaScript. The borrow checker cannot ensure safety. JavaScript or Rust can concurrently access to the bytes. It's unsafe, but it's fast.
Hywan
force-pushed
the
feat-jsvalue-new-typed-array
branch
from
10d238f to
c28e727
Compare
waywardmonkeys
requested changes
Oct 5, 2023
waywardmonkeys
approved these changes
Oct 5, 2023
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #17.This patch implements
JSValue::new_typed_array_with_bytes.This method is marked as unsafe, because bytes aren't copied: they are
borrowed mutably by JavaScript. The borrow checker cannot ensure safety.
JavaScript or Rust can concurrently access to the bytes. It's unsafe,
but it's fast.