fix: #[function_callback] can be used without javascriptcore_sys
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the `#[function_callback]` procedural macro. It was using types from `javascriptcore` and from `javascriptcore_sys`. Problem: if the user uses `javascriptcore` only, and wants to use the macro, it has to add `javascriptcore_sys` as a dependency. To avoid this situation, we expose `javascript_sys` as a (doc hidden) module from `javascript` under the `sys` name. This patch also updates the `#[function_callback]` to use `javascriptcore::sys` instead of `javascriptcore`, and we are good.
waywardmonkeys
approved these changes
Oct 11, 2023
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the
#[function_callback]procedural macro. It was using types fromjavascriptcoreand fromjavascriptcore_sys. Problem: if the user usesjavascriptcoreonly, and wants to use the macro, it has to addjavascriptcore_sysas a dependency.To avoid this situation, we expose
javascript_sysas a (doc hidden) module fromjavascriptunder thesysname.This patch also updates the
#[function_callback]to usejavascriptcore::sysinstead ofjavascriptcore, and we are good.