feat: Add JSTypedArray type
#26
Conversation
This patch implements `JSValue::get_typed_array_type` to know the type of a typed array.
This patch implements `JSValue::is_typed_array` on top of `JSValue::get_typed_array_type`.
This patch introduces the `JSTypedArray` type. It holds the `ty` method (which replaces `JSValue::get_typed_array_type`), `len`, `byte_offset`, `byte_length` and `as_mut_slice`.
Hywan
force-pushed
the
feat-typed-array
branch
from
91bb25c to
ab2f80b
Compare
src/typed_array.rs
Outdated
| /// | ||
| /// # Safety | ||
| /// | ||
| /// Ensure `raw` is valid. |
There was a problem hiding this comment.
Maybe also say it must be a typed array? Or can it reasonably be something else?
There was a problem hiding this comment.
I've updated the doc to say it must be a typed array, but the C API is defensive: if the JSObjectRef isn't a typed array, it shouldn't crash. But still, it must be a JSObjectRef of a typed array.
| } | ||
|
|
||
| /// Returns a value of type [`JSTypedArrayType`] that identifies value's | ||
| /// Typed Array type, or `JSTypedArrayType::None` if the value is not a Typed Array |
There was a problem hiding this comment.
Since this returns a result type, what could, the error be? And can this ever contain something that isn’t a typed array?
There was a problem hiding this comment.
JSTypedArrayType::None represents more or less the error case.
| /// .unwrap(); | ||
| /// assert_eq!(array.len().unwrap(), 5); | ||
| /// ``` | ||
| #[allow(clippy::len_without_is_empty)] |
There was a problem hiding this comment.
Just add an is_empty?
There was a problem hiding this comment.
I wasn't sure it was making sense to have TypedArray::is_empty, because all items exists by definition, just with a default value, so a typed array is never empty.
|
@Hywan Just checking in on this ... |
|
@waywardmonkeys I've pushed my last modification. |
|
Sounds so final! But it looks good to me. |
This PR should ideally be reviewed commit-by-commit.
It introduces the
JSTypedArraytype, and a few other methods likeJSValue::is_typed_arrayandJSValue::as_typed_array. The most important bit is probablyJSTypedArray::as_mut_slice.Happy to get your feedback.