Improve docker ignorefile honoring #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agcty
changed the title
kentcdodds
approved these changes
Aug 3, 2024
kgoggin
added a commit
to kgoggin/epic-stack
that referenced
this pull request
Aug 21, 2024
This part of the docs was made obsolete after epicweb-dev#808
kentcdodds
pushed a commit
that referenced
this pull request
Aug 21, 2024
This part of the docs was made obsolete after #808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.dockerignorefiles are only honored at project root, this PR changes the name toDockerfile.dockerignorewhich makes docker actually honor the given patterns no matter on which path the ignorefile lives.Src: https://stackoverflow.com/questions/71359019/where-to-place-dockerignore-for-docker-build-f-path-to-docker-dockerfile
Right now if you run the following command:
docker build -t epic-stack:latest -f other/Dockerfile .the patterns in
.dockerignoreare in fact not ignored.In addition, fly allows you to configure the docker and ignorefile in the build section of the configuration which means you don't need to move the files to the root anymore for the honoring of the ignore patterns happening.
Overall, this PR removes unneeded code and workarounds that are better solved with the correct configuration.