MenuItem overwrites href prop with "#"

[dstop75]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Problem: MenuItem overwrites href prop with "#". (We want the browser link preview to reflect the link in the menu item, because selecting it will actually navigate there, and not to the top of the current page as indicated by "#".) Please consider including this quick fix.

Here is the diff that solved my problem:

diff --git a/node_modules/react-bootstrap-typeahead/es/components/MenuItem.js b/node_modules/react-bootstrap-typeahead/es/components/MenuItem.js
index 00c67b6..fdc73f5 100644
--- a/node_modules/react-bootstrap-typeahead/es/components/MenuItem.js
+++ b/node_modules/react-bootstrap-typeahead/es/components/MenuItem.js
@@ -21,7 +21,7 @@ var BaseMenuItem = /*#__PURE__*/React.forwardRef(function (_ref, ref) {
         active: active,
         disabled: disabled
       }, className),
-      href: "#",
+      href: props.href || "#",
       onClick: function onClick(e) {
         e.preventDefault();
         !disabled && _onClick && _onClick(e);

This issue body was partially generated by patch-package.

[ericgio]

Hi @dstop75, thanks for filing this issue! Your suggested change seems reasonable; would you mind opening a PR for it?

One thing to note is that MenuItem is provided for convenience and isn't necessarily meant to address every use case. For specific behaviors that aren't supported out of the box, consider creating your own menu item using the useItem hook or withItem HoC.

[ericgio]

Added in v5.2.0