Skip to content

Allow changing colors via SCSS variables #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Allow changing colors via SCSS variables #613

merged 1 commit into from
Feb 5, 2021

Conversation

janbuchar
Copy link
Contributor

What issue does this pull request resolve?

The scss file uses non-default variables for configuration. Unfortunately, these cannot be changed from the outside. This PR aims to change this.

What changes did you make?

The variables were made default and renamed to avoid collisions (I added a rbt- prefix).

Is there anything that requires more attention while reviewing?

I'm aware of no such thing.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #613 (92fee77) into master (6b9ba84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          44       44           
  Lines         661      661           
  Branches      134      134           
=======================================
  Hits          660      660           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9ba84...92fee77. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.849% when pulling 92fee77 on iterait:master into 6b9ba84 on ericgio:master.

@ericgio
Copy link
Owner

ericgio commented Feb 4, 2021

Hey @Teyras, thanks for submitting this PR! Looks like a useful change. Before I merge, do you see any reason why this wouldn't be completely backwards compatible?

@janbuchar
Copy link
Contributor Author

janbuchar commented Feb 4, 2021

@ericgio To my best knowledge, there shouldn't be any BC breaks, except maybe some obscure scss manipulation such as manipulating the styles as raw text during the build process (but BC guarantees usually don't extend to such use cases).

Also, someone might rely on the stylesheet to override variables, but that sounds unlikely, too.

@ericgio ericgio merged commit 1a42d1b into ericgio:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants