Always call onChange when clear button is pressed. #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 683c268 broke this on multi select mode. As result the internal state of the Typeahead component was cleared and it appeared empty, but later refocusing the element, would cause the previously selected options to show up again, as the clearing had not been propagated to the parent component.
|
Fixed in v5.2.1 |
ericgio
added a commit
that referenced
this pull request
Oct 11, 2021
ericgio
added a commit
that referenced
this pull request
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 683c268 broke this on multi
select mode. As result the internal state of the Typeahead component
was cleared and it appeared empty, but later refocusing the element,
would cause the previously selected options to show up again, as the
clearing had not been propagated to the parent component.
What issue does this pull request resolve?
V5.2.0 broke clearButton on multiple select mode.
What changes did you make?
Conditionally calling _handleChange in _handleClear in multiple mode.
Also added a test case.
Is there anything that requires more attention while reviewing?
Nope.