upgrading react-popper to v2 #678
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @trigunam, thanks for submitting this PR. I pulled it down locally and there are a bunch of errors trying to build the examples. |
|
@ericgio Is there a document I can refer to build them locally and fix them? |
|
Instructions for building the examples are here. |
|
Trying with this migration guide: https://popper.js.org/docs/v2/migration-guide/ But looks like there are plenty of errors that needs a complete restructuring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#549
What changes did you make?
Upgraded react-popper to v2
Fixed a test change (not sure if it's correct, please review)
Is there anything that requires more attention while reviewing?
Yes, the test is fixed not code, so not sure if there are any breaking changes due to the upgrade of react-popper.
I really need this change to make it to my project.
Bumped version to alpha-4