Add support for matrix-federation:// scheme to be compatible with new versions of Synapse
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @erikjohnston to review |
|
The tests need fixing, and I'd be minded to keep support for |
MadLittleMods
changed the title
matrix:// to matrix-federation:// to be compatible with new versions of Synapsematrix-federation:// scheme to be compatible with new versions of Synapse
|
@erikjohnston Fixed tests and updated to support both |
erikjohnston
approved these changes
Jan 15, 2025
|
Thanks for the review and merge @erikjohnston 🦌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synapse switched from a
matrix://tomatrix-federation://scheme for internal Synapse routing of outbound federation traffic in matrix-org/synapse#15806 which was first included in Synapse 1.87.0rc1 (2023-06-27).We're adding support for
matrix-federation://in addition to the oldmatrix://scheme.The original set of changes are from @reivilibre's fork that I am trying to upstream. They have been tested and working in the Secure Border Gateway product from Element.