Skip to content

chore(package): explicitly declare js module type #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Feb 24, 2025

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

Node 21.1.0 added a flag to detect module types, that became enabled by default in Node 22.7.0.
Declaring the type will cause Node to skip detection on startup, reducing startup time.

Declaring the package type is also considered good practice according to https://nodejs.org/api/modules.html#enabling.

What changes did you make? (Give an overview)

Updated package.json with main and type keys and values.

@voxpelli voxpelli merged commit b19e133 into eslint-community:main Mar 24, 2025
1 check passed
@Fdawgs Fdawgs deleted the patch-1 branch March 24, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants