Skip to content

refactor: swap-out long nested ternaries for if statements #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2024
Merged

refactor: swap-out long nested ternaries for if statements #850

merged 1 commit into from
Jul 11, 2024

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Jul 11, 2024 •
edited
Loading

No description provided.

@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “Status: Merge Queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “Status: Hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@RebeccaStevens Graphite App
Copy link
Collaborator Author

RebeccaStevens commented Jul 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens mentioned this pull request Jul 11, 2024
Merged
@RebeccaStevens RebeccaStevens marked this pull request as ready for review July 11, 2024 09:46
@RebeccaStevens RebeccaStevens added the Status: Merge Queue Merge the stack with the merge queue label Jul 11, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 11, 2024 •
edited
Loading

Merge activity

  • Jul 11, 5:47 AM EDT: The merge label 'Status: Merge Queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 11, 5:47 AM EDT: RebeccaStevens added this pull request to the Graphite merge queue.
  • Jul 11, 5:51 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jul 11, 5:51 AM EDT: The merge label 'Status: Merge Queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 11, 9:51 AM UTC: The merge label 'Status: Merge Queue' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jul 11, 5:53 AM EDT: The merge label 'Status: Merge Queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 11, 5:53 AM EDT: RebeccaStevens added this pull request to the Graphite merge queue.
  • Jul 11, 5:56 AM EDT: RebeccaStevens merged this pull request with the Graphite merge queue.

@RebeccaStevens RebeccaStevens force-pushed the 07-11-fix_immutable-data_ignoreaccessorpattern_can_now_handle_nonnullexpressions_and_chainexpressions branch from 7ed9531 to f6ff69b Compare July 11, 2024 09:48
@RebeccaStevens RebeccaStevens changed the base branch from 07-11-fix_immutable-data_ignoreaccessorpattern_can_now_handle_nonnullexpressions_and_chainexpressions to main July 11, 2024 09:50
@graphite-app graphite-app bot removed the Status: Merge Queue Merge the stack with the merge queue label Jul 11, 2024
@RebeccaStevens RebeccaStevens force-pushed the 07-11-refactor_swap-out_long_nested_ternaries_for_if_statements branch from 46d5472 to f8e0a75 Compare July 11, 2024 09:53
@RebeccaStevens RebeccaStevens added the Status: Merge Queue Merge the stack with the merge queue label Jul 11, 2024
@RebeccaStevens RebeccaStevens force-pushed the 07-11-refactor_swap-out_long_nested_ternaries_for_if_statements branch from f8e0a75 to 2bfa375 Compare July 11, 2024 09:54
@graphite-app graphite-app bot merged commit 2bfa375 into main Jul 11, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 07-11-refactor_swap-out_long_nested_ternaries_for_if_statements branch July 11, 2024 09:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Merge Queue Merge the stack with the merge queue Status: Released It's now live.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RebeccaStevens