This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Label empty body functions (fixes #92) #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
soda0289
force-pushed
the
fix-empty-body-functions
branch
from
edb6904 to
53f409f
Compare
|
LGTM |
|
Need to add more tests if we go this route |
There are rules in eslint that expect FunctionExpression nodes to contain a body. We should not produce an invalid estree node if we use the estree node types.
soda0289
force-pushed
the
fix-empty-body-functions
branch
from
53f409f to
4069140
Compare
|
LGTM |
|
I'm so sorry it's taken so long to address these PRs @soda0289, so happy to have you on the team now! Let's take stock as soon as we merge in all the breaking changes and release v3! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are rules in eslint that expect FunctionExpression nodes to contain a body. We should not produce an invalid estree node if we use the estree node types.
More information here:
#92 (comment)