Fix: add instanceof to ast-converter

[despairblue]

The BinaryExpression created by instanceof does not set the operator of the node, because the keyword is missing in TOKEN_TO_TEXT.

This was discovered by prettier/prettier#1480

fixes: #252

[jsf-clabot]

All committers have signed the CLA.

[eslintbot]

Thanks for the pull request, @despairblue! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[soda0289]

Thanks for the PR.

Can you add the prefix Fix: or New: to your commit.

I think @JamesHenry was working on fixing this is as well. I'll request a review from him just to make sure there is no issue with this change.

[eslintbot]

Thanks for the pull request, @despairblue! I took a look to make sure it's ready for merging and found some changes are needed:

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[eslintbot]

Thanks for the pull request, @despairblue! I took a look to make sure it's ready for merging and found some changes are needed:

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[despairblue]

@soda0289 Thanks, all done.

[soda0289]

@despairblue
Could you move the test into the folder tests/fixtures/basics as it is not a typescript specific feature.

[eslintbot]

Thanks for the pull request, @despairblue! I took a look to make sure it's ready for merging and found some changes are needed:

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[soda0289]

LGTM!

[eslintbot]

Thanks for the pull request, @despairblue! I took a look to make sure it's ready for merging and found some changes are needed:

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[despairblue]

@soda0289 thanks, I think @eslintbot is happy now as well :)

[platinumazure]

@despairblue If you remove the colon between "fixes" and the issue number, eslintbot will be happy. But we can also fix the commit message on merge, so it's up to you if you want to fix it on your end or not. Thanks!

[eslintbot]

LGTM

[despairblue]

@platinumazure 💡 thank you, done 😄

[JamesHenry]

Yeah, that's super weird, I fixed this on a branch but apparently never submitted it as a PR 😄 I have no memory of either making the change nor why I didn't submit it!