Improve reading efuses #829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
requested review from
jessebraham and
playfulFence
and removed request for
jessebraham
SergioGasquez
force-pushed
the
feat/efuses
branch
from
63b5cff to
b2bfaf6
Compare
|
Can we leverage the CSV files that we use in esp-hal for efuse access here? I'd really like to avoid the manual impls if possible, because it will be a chore for new chip bring up. For example, all chips appear to have a "MAC": https://docs.espressif.com/projects/rust/esp-hal/1.0.0-beta.0/esp32/esp_hal/efuse/constant.MAC.html constant in the CSV's so we can leverage that to only have to process this field in one way. |
|
As we've discussed privately, I've been working on an alternate approach for this. While not quite complete yet, I'm far enough along to be confident that it will work. So, thanks for the PR, but will close this in favour of my upcoming PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to improve the way we handle eFuses, any input is welcome
No public changes, so
skip-changelog