Remove the dependency on cargo from the cargo-espflash package
#841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Apr 15, 2025
jessebraham
force-pushed
the
fixes/remove-cargo-dep
branch
from
facc756 to
eccfef8
Compare
|
I guess this is fine to merge, if there are any issues we can deal with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs more testing, but this PR removes the dependency on
cargofrom thecargo-espflashpackage. This dependency has caused issues a number of times, and it quite enormous, so glad to see it gone.Based on some very limited testing this is still working the same as it did prior to the changes, but I would like to try it out in some more interesting situations to be sure I haven't subtly broken anything.
There are no user-facing changes here, so skipping the
CHANGELOG.mdentry.