Speed up SPI.writePattern() #1920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code kept re-writing fifo's contents over and over and over every iteration, both with data from MISO and then with the supplied data -- this new version writes fifo's contents only once, disables it from being overwritten by data from MISO and as such also skips on writing its contents over and over again with supplied data.
This results in major speed-ups in anything that uses writePattern(), like e.g. with @Links2004 's ILI9341-library there's about a 54% speed-up in fill-screen and anything from 30%-50% speed-up with anything else that uses writePattern() behind-the-scenes.