[SSDP] add schema(Print &) const
#2806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useful when using AsyncWebServer.
earlephilhower
added
merge-conflict
|
Thanks for your PR, but the core and libraries have changed enough that this PR now has a merge conflict. Could you merge it manually with the latest core, so we can consider it for future releases? |
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Nov 17, 2019
Supercedes esp8266#2806 Make SSDP::schema(WiFiClient&) use a by-ref (reduce stack use) Add a SSDP::schema(Print&) From @Palatis' original PR: useful when using AsyncWebServer.
|
Closing as superceded. |
devyte
pushed a commit
that referenced
this pull request
Nov 19, 2019
* [SSDP] add `schema(Print &) const` Supercedes #2806 Make SSDP::schema(WiFiClient&) use a by-ref (reduce stack use) Add a SSDP::schema(Print&) From @Palatis' original PR: useful when using AsyncWebServer. * Use ip.toString, only export Print& schema interface Because WiFiClient inherits a Print interface, replace the ::schema(WiFiClient&) with ::schema(Print&) which is source compatible with existing code and allows the functionality requested in the initial PR. Use ip.toString() in the templates instead of breaking up the octets of the address. * Fix compile errors and backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful when using AsyncWebServer.