Skip to content

Increased I2C buffer size to match Espressif's ESP32 Arduino core #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2019
Merged

Increased I2C buffer size to match Espressif's ESP32 Arduino core #3576

merged 2 commits into from
Jan 20, 2019

Conversation

carlsa
Copy link
Contributor

@carlsa carlsa commented Sep 5, 2017 •
edited
Loading

I have increased the I2C buffer from 32 to 128 bytes to match the buffer length that Espressif uses in their ESP32 Arduino core so that code will be compatible.

https://github.com/espressif/arduino-esp32/blob/master/libraries/Wire/src/Wire.h

@michapr
Copy link

michapr commented Jan 19, 2019

somebody could merge it ?
There are problems as sample with SPS30 (and maybe other devices. Best would be configurable buffer of course ;)
(see Sensirion/embedded-sps#14 )

@d-a-v d-a-v added this to the 2.5.0 milestone Jan 19, 2019
earlephilhower
earlephilhower approved these changes Jan 20, 2019
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only cost is 192 bytes of heap when TWI is used. Seems harmless.

@devyte devyte merged commit cee0796 into esp8266:master Jan 20, 2019
This was referenced Jan 20, 2019
Closed
Closed
@kevinjwalters kevinjwalters mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
component: libraries type: enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@carlsa @michapr @earlephilhower @d-a-v @devyte