Fix pgm_read_ptr() #5735
Merged
Fix pgm_read_ptr() #5735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dereferencing in pgm_read_ptr() macro on 8266 and host. Fixes esp8266#5733
earlephilhower
force-pushed
the
morepgmptrfix
branch
from
fdcfde2 to
562fc69
Compare
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Feb 7, 2019
|
When is the next released planned? As it was also noted in #5733 this issue breaks compatibility with the USB host library and causes our Travis build to fail: https://travis-ci.org/felis/USB_Host_Shield_2.0/jobs/516275113. |
earlephilhower
added a commit
that referenced
this pull request
Apr 11, 2019
* Unaligned access support for pgm_read_word/dword * Fix pgm_read_ptr_aligned() per #5735 * Allow users to use aligned-only via a #define Adding -DPGM_READ_UNALIGNED=0 or #define PGM_READ_UNALIGNED 0 will change the default at compile-time to only aligned (faster, but less compatible) macro implementations. Default is still to allow unaligned accesses.
Lauszus
added a commit
to felis/USB_Host_Shield_2.0
that referenced
this pull request
Apr 14, 2019
tomec-martin
added a commit
to tomec-martin/ArduinoFake
that referenced
this pull request
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dereferencing in pgm_read_ptr() macro on 8266 and host.
Fixes #5733